Author kristjan.jonsson
Recipients kristjan.jonsson, pitrou, vstinner
Date 2013-05-13.10:21:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1368440483.31.0.308483973083.issue17936@psf.upfronthosting.co.za>
In-reply-to
Content
There are two cases when remove_subclass is called:
One when we are changing base classes(the original use of this function), and in this case we must find the correct one.

The second one is when the class is being deleted, for housekeeping of the weakrefs.
I worry that your alternative will cause us to walk the entire list in the second case because it will be called when the weakref has been cleared, so  it will never find itself in the list, only None.  I'll make some tests to verify.

I think perhaps a small adjustment, an "exact" flag or something, can be added to differentiate between the two cases....
History
Date User Action Args
2013-05-13 10:21:23kristjan.jonssonsetrecipients: + kristjan.jonsson, pitrou, vstinner
2013-05-13 10:21:23kristjan.jonssonsetmessageid: <1368440483.31.0.308483973083.issue17936@psf.upfronthosting.co.za>
2013-05-13 10:21:23kristjan.jonssonlinkissue17936 messages
2013-05-13 10:21:23kristjan.jonssoncreate