Author neologix
Recipients neologix, pitrou, vstinner
Date 2013-05-07.07:14:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAH_1eM3aSA=a903uBbj9_=8aSc=zF=DF0vpyy5Km+UJV3P0Hog@mail.gmail.com>
In-reply-to <1367878963.98.0.0610936771008.issue17917@psf.upfronthosting.co.za>
Content
> PC/_msi.c: Oh, here you should remove cast to int. Example:
>
> PyModule_AddIntMacro(m, (int)MSIDBOPEN_CREATEDIRECT);
>
> I'm surprised that the does compile. You may have a "(int)MSIDBOPEN_CREATEDIRECT" variable :-)

Probably, good catch ;-)
I'll fix that.

> Modules/fcntlmodule.c and Modules/posixmodule.c are using explicit cast to long. I don't know if there is a good reason for such cast.

There's a prototype, so arguments are implicitly converted to long:

PyAPI_FUNC(int) PyModule_AddIntConstant(PyObject *, const char *, long);
#define PyModule_AddIntMacro(m, c) PyModule_AddIntConstant(m, #c, c)
History
Date User Action Args
2013-05-07 07:14:18neologixsetrecipients: + neologix, pitrou, vstinner
2013-05-07 07:14:18neologixlinkissue17917 messages
2013-05-07 07:14:18neologixcreate