This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients Arfrever, berker.peksag, dlam, eric.araujo, ezio.melotti, pconnell, pitrou, rhettinger
Date 2013-05-04.22:20:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1367706029.33.0.0924425855807.issue11698@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch. (Yes, I'm looking at this a bit late :-))

First, there seems to be a problem with the repr() of of.stat() results:

 ./python -c "import os; print(os.stat('LICENSE'))"
posix.stat_result(st_mode=33204, st_ino=6553619, st_dev=2053, st_nlink=1, st_uid=1000, st_gid=1000, st_size=15089, st_atime=1367693898, st_mtime=1365264866, st_ctime=1366481591, st_atime=1367693898.528636, st_mtime=1365264866.4163036, st_ctime=1366481591.9862735, st_atime_ns=1367693898528635928, st_mtime_ns=1365264866416303676, st_ctime_ns=1366481591986273627, st_blksize=4096, st_blocks=32, st_rdev=0)

As you see, fields such as "st_atime" are duplicated.

There are other issues with the patch:

* C variable declarations should always be at the beginning of blocks (otherwise it's not C89-compliant)

* C++-style comments (//) are forbidden

* I don't understand in which circumstances `Py_TYPE(obj)->tp_members[i-n_unnamed_fields].name` can be NULL
History
Date User Action Args
2013-05-04 22:20:29pitrousetrecipients: + pitrou, rhettinger, ezio.melotti, eric.araujo, Arfrever, berker.peksag, dlam, pconnell
2013-05-04 22:20:29pitrousetmessageid: <1367706029.33.0.0924425855807.issue11698@psf.upfronthosting.co.za>
2013-05-04 22:20:29pitroulinkissue11698 messages
2013-05-04 22:20:29pitroucreate