Author ncoghlan
Recipients benjamin.peterson, ncoghlan, pitrou
Date 2013-04-21.04:44:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1366519498.29.0.942044951043.issue17807@psf.upfronthosting.co.za>
In-reply-to
Content
Just a couple of minor comments on review. Everything else I looked for (including the path where a generator failing to stop during frame deallocation leads to reporting an unraisable exception) seemed fine.

One aspect I find interesting is that we've had other patches which proposed reducing the level of poking around generators needed to do inside frame objects by moving (some of) that state to the generators. This patch goes the other way, by moving the related cleanup functionality into the frame objects.

I think that's actually a reasonable option - the frame is always going to be involved at some point in order to actually execute the cleanup code, so our only real chance to break the cycle is to eliminate the generator's involvement.
History
Date User Action Args
2013-04-21 04:44:58ncoghlansetrecipients: + ncoghlan, pitrou, benjamin.peterson
2013-04-21 04:44:58ncoghlansetmessageid: <1366519498.29.0.942044951043.issue17807@psf.upfronthosting.co.za>
2013-04-21 04:44:58ncoghlanlinkissue17807 messages
2013-04-21 04:44:57ncoghlancreate