Author r.david.murray
Recipients demian.brecht, ezio.melotti, orsenthil, r.david.murray, terry.reedy
Date 2013-04-20.12:41:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1366461689.32.0.575841742945.issue17272@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for working on this, Demian.  I made some review comments, mostly style things about the tests.

There's one substantial comment about the change in behaivor of the full_url property though (before patch it does not include the fragment, after the patch it does).  We need to think about the implications of that change in terms of backward compatibility.  It makes more sense, but how likely is it to break working code?
History
Date User Action Args
2013-04-20 12:41:29r.david.murraysetrecipients: + r.david.murray, terry.reedy, orsenthil, ezio.melotti, demian.brecht
2013-04-20 12:41:29r.david.murraysetmessageid: <1366461689.32.0.575841742945.issue17272@psf.upfronthosting.co.za>
2013-04-20 12:41:29r.david.murraylinkissue17272 messages
2013-04-20 12:41:29r.david.murraycreate