Author zach.ware
Recipients Arfrever, alex, brett.cannon, eric.araujo, ezio.melotti, jcea, meador.inge, pitrou, r.david.murray, rhettinger, serhiy.storchaka, zach.ware
Date 2013-04-16.17:24:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1366133076.47.0.991256091086.issue16694@psf.upfronthosting.co.za>
In-reply-to
Content
Thank you for the review, Raymond.

Since Serhiy agrees that the _operator __func__s are unnecessary, here's a v13 that removes them.  Again, I'm not a native C speaker, so these new changes in _operator.c deserve a bit of extra scrutiny.  Everything builds and still passes the test suite, though.

Also changed in this patch, test_pow and test_inplace remove explicit testing of __func__s.  Those tests are useless, as they are merely rerunning already run tests on the same function with a different name, which is confirmed by test_dunder_is_original.  I can extend that test with an explicit list of funcs which should have a __func__ if anyone thinks it's worth it.
History
Date User Action Args
2013-04-16 17:24:36zach.waresetrecipients: + zach.ware, brett.cannon, rhettinger, jcea, pitrou, ezio.melotti, eric.araujo, Arfrever, alex, r.david.murray, meador.inge, serhiy.storchaka
2013-04-16 17:24:36zach.waresetmessageid: <1366133076.47.0.991256091086.issue16694@psf.upfronthosting.co.za>
2013-04-16 17:24:36zach.warelinkissue16694 messages
2013-04-16 17:24:36zach.warecreate