Author neologix
Recipients benjamin.peterson, georg.brandl, giampaolo.rodola, larry, neologix, pitrou, sbt, sultanqasim
Date 2013-04-15.15:00:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAH_1eM2=hy+L21S+iwQW8eXBrbPSS3wLnzFQ==MVNYs-hJgxsQ@mail.gmail.com>
In-reply-to <1366026455.45.0.255537741452.issue17707@psf.upfronthosting.co.za>
Content
> Maybe I'm misinterpreting what you wrote but the test fails before the patch and succeeds after it so what's the point in adding multiple tests with different timeouts?

Well, the test you added tests explicitely for a value < 1s because
this specific bug was due to a rounding error, but I think it could be
interesting to check a couple more values, within a reasonable range
(not too long).
It's just a matter of calling it in a loop, but if you don't deem it
necessary, that's fine with me.

> Not sure what you refer to here. Feel free to submit a patch if you want.

See e.g. :
http://hg.python.org/cpython/file/413c0b0a105f/Lib/test/lock_tests.py#l65
History
Date User Action Args
2013-04-15 15:00:06neologixsetrecipients: + neologix, georg.brandl, pitrou, larry, giampaolo.rodola, benjamin.peterson, sbt, sultanqasim
2013-04-15 15:00:05neologixlinkissue17707 messages
2013-04-15 15:00:05neologixcreate