Author serhiy.storchaka
Recipients alexandre.vassalotti, pitrou, serhiy.storchaka
Date 2013-04-14.08:33:28
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1365928409.03.0.120241329226.issue17711@psf.upfronthosting.co.za>
In-reply-to
Content
I think a string with character codes < 256 will be better for test_protocol0_is_ascii_only(). It can be latin1 encoded (Python 2 allows any 8-bit strings).

PyUnicode_AsASCIIString() can be slower than _PyUnicode_AsStringAndSize() (actually PyUnicode_AsUTF8AndSize()) because the latter can use cached value. You can check if the persistent id only contains ASCII characters by checking PyUnicode_GET_LENGTH(pid_str) == size.

And what are you going to do with the fact that in Python 2 you can pickle non-ascii persistent ids, which will not be able to unpickle in Python 3?
History
Date User Action Args
2013-04-14 08:33:29serhiy.storchakasetrecipients: + serhiy.storchaka, pitrou, alexandre.vassalotti
2013-04-14 08:33:29serhiy.storchakasetmessageid: <1365928409.03.0.120241329226.issue17711@psf.upfronthosting.co.za>
2013-04-14 08:33:29serhiy.storchakalinkissue17711 messages
2013-04-14 08:33:28serhiy.storchakacreate