This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author zach.ware
Recipients brian.curtin, sbt, terry.reedy, tim.golden, zach.ware
Date 2013-04-08.17:08:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAKJDb-Pr5+WZ3P7ExwZq288+R3MYyLmobZjVqX9ypohtcABzCA@mail.gmail.com>
In-reply-to <1365338752.27.0.647172851636.issue16895@psf.upfronthosting.co.za>
Content
> You seem to end your subroutines (or whatever they are called) using "goto end" rather than "exit /b".  Since popd follows the "end" label, does this mean that you get a popd after calling each subroutine?

Yes.

> Is this intended and can it cause unmatched pushd/popd-s?

It is intended and it can, but so far I haven't run into any trouble
with it.  However, I have realized that I haven't done any testing
with some pushd's already on the stack...  I'll do some more looking
into that, and may have to implement either some form of callback
labels or counting pushd's to properly popd.

> (I am not familiar with writing batch files.)
>
> Also, I think 32 bit builds should be the default.  Many people with 64 bit Windows are using Visual Studio Express which only has 32 bit support.

Fair point.  I suppose I had been assuming that the error message from
not finding the proper vcvars*.bat file would be an indication to pass
'--without-64-bit' to configure.bat, but it is much nicer to just fall
back to 32 bit.  Also, it would be nice to just implode from the start
if there is no compiler available.  Next version of the patch will do
both of these things in configure.bat; quit with an error message if
%VS100COMNTOOLS% is not defined, and check for the existence of
%VS100COMNTOOLS%\..\..\VC\bin\x86_amd64\vcvarsx86_amd64.bat before
setting %PY_PLATFORM% to x64.

Thanks for the comments.
History
Date User Action Args
2013-04-08 17:08:53zach.waresetrecipients: + zach.ware, terry.reedy, tim.golden, brian.curtin, sbt
2013-04-08 17:08:53zach.warelinkissue16895 messages
2013-04-08 17:08:53zach.warecreate