Message 185763 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	barry
Recipients	barry, brett.cannon, docs@python, eric.smith
Date	2013-04-01.19:59:22
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<20130401155918.59ccd480@anarchist>
In-reply-to	<1364845219.29.0.117747302284.issue17566@psf.upfronthosting.co.za>

Content
On Apr 01, 2013, at 07:40 PM, Brett Cannon wrote: >Barry, Eric: can you clarify why you made module_repr an abstractmethod and >thus require its overloading? Maybe Eric can, but I can't. ;) I honestly don't remember why we made it abstract, except perhaps because we put it in the Loader class which already had an abstract load_module() method. >It seems like its default is fine and you should only need to overload it >when you can say something better than the default. Note that moduleobject.c can handle the case of a missing or uncallable module_repr() attribute. Then it implements the defaults specified in PEP 420.

On Apr 01, 2013, at 07:40 PM, Brett Cannon wrote:

>Barry, Eric: can you clarify why you made module_repr an abstractmethod and
>thus require its overloading?

Maybe Eric can, but I can't. ;) I honestly don't remember why we made it
abstract, except perhaps because we put it in the Loader class which already
had an abstract load_module() method.

>It seems like its default is fine and you should only need to overload it
>when you can say something better than the default.

Note that moduleobject.c can handle the case of a missing or uncallable
module_repr() attribute.  Then it implements the defaults specified in PEP
420.

History
Date	User	Action	Args
2013-04-01 19:59:23	barry	set	recipients: + barry, brett.cannon, eric.smith, docs@python
2013-04-01 19:59:22	barry	link	issue17566 messages
2013-04-01 19:59:22	barry	create