Author ncoghlan
Recipients barry, durin42, gward, ncoghlan, pitrou, r.david.murray, terry.reedy
Date 2013-03-19.05:29:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1363670970.12.0.108440353062.issue17445@psf.upfronthosting.co.za>
In-reply-to
Content
Ah, I forgot we didn't do within-line diffs. If we did those, then latin-1 would be less bad choice than ascii+surrogateescape. As it is, either should work in this case (since they just need to tunnel the raw bytes, and aren't being sliced at all).

I agree with most of Terry's comments, but think the case can be made this is a bug worth fixing in 3.3 (it's definitely borderline, but making it feasible to port Mercurial is a pretty big gain for a relatively tiny risk).

3.2 is about to enter security fix only mode though, so dropping that from the list of affected versions - while the fix should apply just fine, it's definitely not appropriate to make a change like this in the final planned maintenance release.
History
Date User Action Args
2013-03-19 05:29:30ncoghlansetrecipients: + ncoghlan, barry, gward, terry.reedy, pitrou, durin42, r.david.murray
2013-03-19 05:29:30ncoghlansetmessageid: <1363670970.12.0.108440353062.issue17445@psf.upfronthosting.co.za>
2013-03-19 05:29:30ncoghlanlinkissue17445 messages
2013-03-19 05:29:29ncoghlancreate