Author pitrou
Recipients Arfrever, christian.heimes, giampaolo.rodola, jcea, maker, pitrou
Date 2013-03-16.18:37:54
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1363459074.74.0.933650920891.issue16692@psf.upfronthosting.co.za>
In-reply-to
Content
Ok, some review comments:

+   .. warning:: requires at least openssl version 1.0.1

+   .. warning:: requires at least openssl version 1.0.1

The warnings are not warranted here. You might simply say "Available only with openssl version 1.0.1+."

+def skip_if_unsupported_tlsv1_1(func):

This decorator looks like it would be impressed in a simpler way using unittest.skipIf (or unittest.skipUnless).

+            try_protocol_combo(ssl.PROTOCOL_TLSv1_1, ssl.PROTOCOL_SSLv23, False,
+                               client_options=ssl.OP_NO_TLSv1_1)

Not sure why you test only with OP_NO_TLSv1_1. It would be nice to check that connecting succeeds from a TLSv1_1 client on a SSLv23 server.
History
Date User Action Args
2013-03-16 18:37:54pitrousetrecipients: + pitrou, jcea, giampaolo.rodola, christian.heimes, Arfrever, maker
2013-03-16 18:37:54pitrousetmessageid: <1363459074.74.0.933650920891.issue16692@psf.upfronthosting.co.za>
2013-03-16 18:37:54pitroulinkissue16692 messages
2013-03-16 18:37:54pitroucreate