Message183908
Looks fine. I'd say that it would be great to add slicing to deque!
There's one oddity in the code, but it was there before the patch -- the local variable name __waiters is pretty silly. It appears to be a micro-optimization to avoid using self._waiters more than once; even if that is worth it (I kind of doubt it), the __private name is wrong and misguided. |
|
Date |
User |
Action |
Args |
2013-03-11 01:46:52 | gvanrossum | set | recipients:
+ gvanrossum, tim.peters, rhettinger, jcea, pitrou, asvetlov, neologix, python-dev |
2013-03-11 01:46:52 | gvanrossum | set | messageid: <1362966412.45.0.0180901069144.issue17385@psf.upfronthosting.co.za> |
2013-03-11 01:46:52 | gvanrossum | link | issue17385 messages |
2013-03-11 01:46:51 | gvanrossum | create | |
|