This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author zbysz
Recipients amaury.forgeotdarc, docs@python, zbysz
Date 2013-03-08.14:44:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <20130308144432.GH4278@in.waw.pl>
In-reply-to <1362753018.25.0.505213428378.issue17380@psf.upfronthosting.co.za>
Content
On Fri, Mar 08, 2013 at 02:30:18PM +0000, Amaury Forgeot d'Arc wrote:
> 
> Amaury Forgeot d'Arc added the comment:
> 
> The return value for error conditions should be -1.
> 
> - typeobject.c checks with "< 0"
> - in _iomodule.c, there is "== -1"
> - and pygobject/gobject/gobjectmodule.c just does::
>     if (...tp_init(...))
>         PyErr_Print();
That's not very nice. Would it make sense to unify those
checks, e.g. for "initproc() < 0"? Than the documentation
could be updated.

Zbyszek
History
Date User Action Args
2013-03-08 14:44:33zbyszsetrecipients: + zbysz, amaury.forgeotdarc, docs@python
2013-03-08 14:44:33zbyszlinkissue17380 messages
2013-03-08 14:44:33zbyszcreate