Author r.david.murray
Recipients karlcow, orsenthil, r.david.murray
Date 2013-03-03.15:42:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1362325362.04.0.981168090469.issue17322@psf.upfronthosting.co.za>
In-reply-to
Content
Here is a modified patch with the tests moved to test_urllib2.  I'll give people some time to comment on whether this should be applied at all, and if so if it should be backported.  I'm leaning toward doing both, at the moment.

Karl, thanks for the report and patch.  The urllib tests could use a bit of reorganization to make them more discoverable, but I don't know that that is very likely to happen :)

The case of doing an add_header with newlines in it is probably worth a separate issue.  We fixed a similar issue in the email package a while back, but that one was much more likely to be an issue since it is much more likely for a program to be adding headers to an email message based on user input than it is to be adding headers to a Request based on user input.  But I'm sure it does happen, so it is probably worth fixing.
History
Date User Action Args
2013-03-03 15:42:42r.david.murraysetrecipients: + r.david.murray, orsenthil, karlcow
2013-03-03 15:42:42r.david.murraysetmessageid: <1362325362.04.0.981168090469.issue17322@psf.upfronthosting.co.za>
2013-03-03 15:42:42r.david.murraylinkissue17322 messages
2013-03-03 15:42:41r.david.murraycreate