Message183347
Hi Joar,
just a detail: is there a reason for the asymmetric check for timedelta isinstance (and raising NotImplemented)? And BTW. isn't a double check for the __sub__ case (or have I missed something)?
+ def __add__(self, other):
+ "Add a time and a timedelta"
+ if not isinstance(other, timedelta):
+ return NotImplemented
vs.
…
+ def __sub__(self, other):
+ "Subtract a time and a timedelta."
+ if isinstance(other, timedelta):
+ return self + -other
+ return NotImplemented
regards,
francis |
|
Date |
User |
Action |
Args |
2013-03-02 20:16:03 | francismb | set | recipients:
+ francismb, ronaldoussoren, belopolsky, eric.smith, maker, petri.lehtinen, thezulk, joar, jbatista |
2013-03-02 20:16:03 | francismb | set | messageid: <1362255363.35.0.683612146334.issue17267@psf.upfronthosting.co.za> |
2013-03-02 20:16:03 | francismb | link | issue17267 messages |
2013-03-02 20:16:03 | francismb | create | |
|