Message183243
I had put in the renaming because "ioclass" is not defined in the class itself, only in the subclasses. So, instantiating it and using dumps/loads would be meaningless and would raise an error. Which is similar to the behavior of an abstract class.
Also, the "if(self.f):" part can be improved as you said and I looked at the patch for other similar mistakes. But, it's an isolated mistake (at lines 33 and 74) and so maybe it can be fixed during the merge itself? |
|
Date |
User |
Action |
Args |
2013-03-01 07:27:09 | Aman.Shah | set | recipients:
+ Aman.Shah, pitrou, alexandre.vassalotti, Arfrever, r.david.murray, serhiy.storchaka |
2013-03-01 07:27:09 | Aman.Shah | set | messageid: <1362122829.58.0.478016783742.issue17299@psf.upfronthosting.co.za> |
2013-03-01 07:27:09 | Aman.Shah | link | issue17299 messages |
2013-03-01 07:27:09 | Aman.Shah | create | |
|