Message183238
Aman: another nit: PEP8 calls for no unneeded parentheses around logical expressions, so things like:
if(self.f):
should be written:
if self.f:
in order to adhere to our coding style.
Also, it's not obvious to me that there is any reason to rename the base classes (PicklerTests->AbstractIOPicklerTests, and same for Persistent test).
Finally, rereading Serhiy's note, Python3 only has "general IO streams", both non-IO files and cStringIO.StringIO are gone. So this really is a 2.7-only issue, and only worth doing because 2.7 is a long term maintenance release. |
|
Date |
User |
Action |
Args |
2013-02-28 22:11:41 | r.david.murray | set | recipients:
+ r.david.murray, pitrou, alexandre.vassalotti, Arfrever, serhiy.storchaka, Aman.Shah |
2013-02-28 22:11:41 | r.david.murray | set | messageid: <1362089501.54.0.271954437121.issue17299@psf.upfronthosting.co.za> |
2013-02-28 22:11:41 | r.david.murray | link | issue17299 messages |
2013-02-28 22:11:41 | r.david.murray | create | |
|