Author Kim.Gräsman
Recipients Kim.Gräsman, terry.reedy
Date 2013-02-22.20:05:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1361563535.91.0.63105084809.issue17233@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for your response!

> I agree that send: and reply: should be formatted the same, 
> so the reply: line should include the headers *with* the
> values.

OK, yeah, that would avoid having to specify request/response for headers as well, I think.

> The current header line seems to be truncated after Date,
> without even its ':',

It doesn't look like there are any trailing colons on header names. Rather, all header names have a "header: " prefix. As you can see, it's pretty hard to parse :-)

> and it is definitely missing a newline.

Glad we agree!

> Are you claiming that there are other missing newlines?

It's not visible in the attached log, but if you add print() statements in a script using http.client, the output usually ends up at the end of one of http.client's log lines. So I think every log output is missing a newline.

> I don't understand the lines with
> send: bytearray(b'\x00\x00\x00\x00\x00\x00\x00\x00\x00')

We're sending binary data in our HTTP body, so this is the actual content. For some reason, though, the fact that it's binary seems to force it onto its own line.

> Patches are good, but you might wait a few days
> for other comments as I am definitely not an http expert.

OK, thanks again!
History
Date User Action Args
2013-02-22 20:05:35Kim.Gräsmansetrecipients: + Kim.Gräsman, terry.reedy
2013-02-22 20:05:35Kim.Gräsmansetmessageid: <1361563535.91.0.63105084809.issue17233@psf.upfronthosting.co.za>
2013-02-22 20:05:35Kim.Gräsmanlinkissue17233 messages
2013-02-22 20:05:35Kim.Gräsmancreate