Author serhiy.storchaka
Recipients amaury.forgeotdarc, mark.dickinson, pitrou, python-dev, serhiy.storchaka, sjoerd, skrah, vstinner
Date 2013-02-11.09:21:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1360574470.43.0.756414978612.issue4591@psf.upfronthosting.co.za>
In-reply-to
Content
There is a problem with test_pwd on 64-bit platform. It expects KeyError on pwd.getpwuid(sys.maxsize). Actually the test is not looks robust. On 32-bit platform sys.maxsize = 2**31-1 < 2**32 and this value only by chance was not in the user database. On 64-bit platform sys.maxsize > 2**32 and in old code it was wrapped to 2**31-1 C unsigned int value and this value only by chance was not in the user database. New code doesn't wrap the value to C unsigned int and raises an overflow exception.

What should I change, a test or a raised exception?
History
Date User Action Args
2013-02-11 09:21:10serhiy.storchakasetrecipients: + serhiy.storchaka, sjoerd, amaury.forgeotdarc, mark.dickinson, pitrou, vstinner, skrah, python-dev
2013-02-11 09:21:10serhiy.storchakasetmessageid: <1360574470.43.0.756414978612.issue4591@psf.upfronthosting.co.za>
2013-02-11 09:21:10serhiy.storchakalinkissue4591 messages
2013-02-11 09:21:10serhiy.storchakacreate