Author michael.foord
Recipients Arfrever, Julian, Yaroslav.Halchenko, abingham, bfroehle, borja.ruiz, brett.cannon, brian.curtin, chris.jerdonek, eric.araujo, eric.snow, exarkun, ezio.melotti, fperez, hpk, michael.foord, nchauvat, ncoghlan, pitrou, r.david.murray, santoso.wijaya, serhiy.storchaka, spiv
Date 2013-02-10.12:57:59
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1360501079.74.0.393852890088.issue16997@psf.upfronthosting.co.za>
In-reply-to
Content
My concern is that this re-uses the existing TestResult.add* methods in a different way (including calling addError multiple times). This can break existing tools.

Fix suggested by lifeless on IRC. A sub test failure / success / exception calls the following TestResult method:

   addSubTest(test, sub_id, err_or_None)


If we're using a TestResult object that doesn't have these methods (an "old" result objects) then the test can *stop* (i.e. revert to the old behaviour before sub tests existed).
History
Date User Action Args
2013-02-10 12:57:59michael.foordsetrecipients: + michael.foord, brett.cannon, spiv, exarkun, ncoghlan, pitrou, ezio.melotti, eric.araujo, Arfrever, r.david.murray, brian.curtin, hpk, fperez, chris.jerdonek, Yaroslav.Halchenko, santoso.wijaya, nchauvat, Julian, abingham, eric.snow, serhiy.storchaka, borja.ruiz, bfroehle
2013-02-10 12:57:59michael.foordsetmessageid: <1360501079.74.0.393852890088.issue16997@psf.upfronthosting.co.za>
2013-02-10 12:57:59michael.foordlinkissue16997 messages
2013-02-10 12:57:59michael.foordcreate