Message 181290 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	serhiy.storchaka
Recipients	Gilles.Louppe, belopolsky, eric.smith, gregory.p.smith, loewis, pitrou, rybesh, serhiy.storchaka, vstinner
Date	2013-02-03.19:49:20
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1359920960.16.0.42459287138.issue7358@psf.upfronthosting.co.za>
In-reply-to

Content
> Suggested workaround: use io.BytesIO instead of cStringIO. Well, maybe we can replace cStringIO by io.BytesIO in cPickle (and other places). > comments on the patch... in short: your patch is changing an ABI and isn't suitable for a maintenance release. Isn't this a private API? > I'm not sure how much we can usefully do to cStringIO in a maintenance release. I'd be inclined to close as wontfix as io.BytesIO is available. We can't just close this issue. cStringIO crashes Python. We can use another approach. Change cStringIO so that user can't write or read more than INT_MAX bytes at a time (an exception will be raised instead of crash), but can write more than INT_MAX bytes in sum and get all string with getvalue(). This will preserve an ABI.

> Suggested workaround: use io.BytesIO instead of cStringIO.

Well, maybe we can replace cStringIO by io.BytesIO in cPickle (and other places).

> comments on the patch... in short: your patch is changing an ABI and isn't suitable for a maintenance release.

Isn't this a private API?

> I'm not sure how much we can usefully do to cStringIO in a maintenance release.  I'd be inclined to close as wontfix as io.BytesIO is available.

We can't just close this issue. cStringIO crashes Python. We can use another approach. Change cStringIO so that user can't write or read more than INT_MAX bytes at a time (an exception will be raised instead of crash), but can write more than INT_MAX bytes in sum and get all string with getvalue(). This will preserve an ABI.

History
Date	User	Action	Args
2013-02-03 19:49:20	serhiy.storchaka	set	recipients: + serhiy.storchaka, loewis, gregory.p.smith, belopolsky, pitrou, vstinner, eric.smith, rybesh, Gilles.Louppe
2013-02-03 19:49:20	serhiy.storchaka	set	messageid: <1359920960.16.0.42459287138.issue7358@psf.upfronthosting.co.za>
2013-02-03 19:49:20	serhiy.storchaka	link	issue7358 messages
2013-02-03 19:49:20	serhiy.storchaka	create