Author terry.reedy
Recipients Arfrever, jcea, mark.dickinson, serhiy.storchaka, terry.reedy
Date 2013-02-02.22:58:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1359845926.88.0.489462488331.issue16686@psf.upfronthosting.co.za>
In-reply-to
Content
I do not have the knowledge needed to review the code, but I took a brief look. The three doc patches need a verb to be proper English. "Samples truncated in case of overflow." should be "Samples are truncated in case of overflow." in both places. I think "Samples wrapped around in case of overflow." could be rewritten as "Samples wrap around in case of overflow.", though adding 'are' works too.

In the C code comment:

     /* Passing a short** for an 's' argument is correct only
        if the string contents is aligned for interpretation
        as short[]. Due to the definition of PyBytesObject,
-       this is currently (Python 2.6) the case. */
+       this is currently (Python 2.6) the case.
+       XXX: It's not true for memoryview. */

Is whatever the case in 2.6 only (if so, drop obsolete) or since 2.6. If the latter, I would rewrite as "this is the case since Python 2.6.".
The addition is not clear to me. Are you implying that something should be made true for memory view (in a future patch)?
History
Date User Action Args
2013-02-02 22:58:46terry.reedysetrecipients: + terry.reedy, jcea, mark.dickinson, Arfrever, serhiy.storchaka
2013-02-02 22:58:46terry.reedysetmessageid: <1359845926.88.0.489462488331.issue16686@psf.upfronthosting.co.za>
2013-02-02 22:58:46terry.reedylinkissue16686 messages
2013-02-02 22:58:46terry.reedycreate