Author sfllaw
Recipients jcea, jcon, python-dev, rhettinger, serhiy.storchaka, sfllaw
Date 2013-02-02.18:40:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1359830427.92.0.41409565917.issue16398@psf.upfronthosting.co.za>
In-reply-to
Content
Raymond, looking at your patch, can we assert that deque->leftblock is never equal to deque->rightblock? If not, you need to use memmove() instead of memcpy(), which is unsafe for overlapping arrays.

It is not clear to me that this invariant is true. At the very least, an assertion should be there to protect future refactorings.
History
Date User Action Args
2013-02-02 18:40:27sfllawsetrecipients: + sfllaw, rhettinger, jcea, python-dev, jcon, serhiy.storchaka
2013-02-02 18:40:27sfllawsetmessageid: <1359830427.92.0.41409565917.issue16398@psf.upfronthosting.co.za>
2013-02-02 18:40:27sfllawlinkissue16398 messages
2013-02-02 18:40:27sfllawcreate