This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author nneonneo
Recipients nneonneo
Date 2013-01-27.09:10:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1359277856.16.0.886323650341.issue17051@psf.upfronthosting.co.za>
In-reply-to
Content
[From http://stackoverflow.com/questions/12648737/huge-memory-leak-in-repeated-os-path-isdir-calls]

os.path.isdir() leaks memory under Windows in Python 2.7. The core cause is this snippet:

Modules/posixmodule.c:4226:
    if (!PyArg_ParseTuple(args, "et:_isdir",
                          Py_FileSystemDefaultEncoding, &path))
        return NULL;

    attributes = GetFileAttributesA(path);
    if (attributes == INVALID_FILE_ATTRIBUTES)
        Py_RETURN_FALSE;

check:
    if (attributes & FILE_ATTRIBUTE_DIRECTORY)
        Py_RETURN_TRUE;
    else
        Py_RETURN_FALSE;


The buffer returned by the "et" ParseTuple format must be freed after use. Since it isn't freed, we get a memory leak here.

Patch:

--- a/Modules/posixmodule.c	Mon Apr 09 19:04:04 2012 -0400
+++ b/Modules/posixmodule.c	Sun Jan 27 04:10:34 2013 -0500
@@ -4226,6 +4226,7 @@
         return NULL;
 
     attributes = GetFileAttributesA(path);
+    PyMem_Free(path);
     if (attributes == INVALID_FILE_ATTRIBUTES)
         Py_RETURN_FALSE;
History
Date User Action Args
2013-01-27 09:10:56nneonneosetrecipients: + nneonneo
2013-01-27 09:10:56nneonneosetmessageid: <1359277856.16.0.886323650341.issue17051@psf.upfronthosting.co.za>
2013-01-27 09:10:56nneonneolinkissue17051 messages
2013-01-27 09:10:55nneonneocreate