This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author doko
Recipients BreamoreBoy, LRN, Ray.Donnelly, WhiteTiger, alesko, amaury.forgeotdarc, davidfraser, doko, eric.araujo, georg.brandl, giampaolo.rodola, jhuntley, kalev, lkcl, rpetrov, rschoon.old, schmir, scott.tsai, tarek, tshepang
Date 2013-01-25.15:44:24
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1359128664.47.0.801938322492.issue3871@psf.upfronthosting.co.za>
In-reply-to
Content
some random comments about py3k-20121004-MINGW.patch:

- Modules/_ctypes/libffi_msvc/win32.S
  Please can you get rid of libffi_msvc and use libffi?
  afaics, libffi has support for mingw32.

- there seem to be chunks which are unrelated to mingw, like:

@@ -830,15 +926,18 @@ class PyBuildExt(build_ext):
             if have_usable_openssl:
                 # The _hashlib module wraps optimized implementations
                 # of hash functions from the OpenSSL library.
+                # NOTE: _hashlib require only OpenSSL crypto library !
                 exts.append( Extension('_hashlib', ['_hashopenssl.c'],
                                        depends = ['hashlib.h'],
                                        include_dirs = ssl_incs,
                                        library_dirs = ssl_libs,
-                                       libraries = ['ssl', 'crypto']) )
+                                       libraries = ['crypto']) )

please file separate issues.


- why setup_info.in. looks like something which could be done with get_config_var.

- why re-reading files in setup.py, and grepping these for config options?


I think the patch would benefit from splitting it up into several self-contained chunks.

did you try to do builds for windows and linux after this patch was applied?
History
Date User Action Args
2013-01-25 15:44:24dokosetrecipients: + doko, georg.brandl, lkcl, amaury.forgeotdarc, davidfraser, giampaolo.rodola, schmir, scott.tsai, tarek, eric.araujo, rpetrov, rschoon.old, WhiteTiger, BreamoreBoy, LRN, alesko, tshepang, kalev, Ray.Donnelly, jhuntley
2013-01-25 15:44:24dokosetmessageid: <1359128664.47.0.801938322492.issue3871@psf.upfronthosting.co.za>
2013-01-25 15:44:24dokolinkissue3871 messages
2013-01-25 15:44:24dokocreate