Message180194
Chris, you said (in the review) "Hmm, since this is for maintenance releases ... This change could cause "working" code to no longer work."
I understood from our original message that you wanted it to change since it is inconsistent. I vote for changing it (so that it gives an error) but since this is my first bug/patch, I don't really know what usually happens.
Either way, I adjusted the patch conform your comments. For now I removed the original changes to handle negative numbers and changed the message from "nargs must be > 0" to "nargs must be != 0". |
|
Date |
User |
Action |
Args |
2013-01-18 14:48:19 | Robert | set | recipients:
+ Robert, bethard, chris.jerdonek |
2013-01-18 14:48:19 | Robert | set | messageid: <1358520499.76.0.34572660284.issue16970@psf.upfronthosting.co.za> |
2013-01-18 14:48:19 | Robert | link | issue16970 messages |
2013-01-18 14:48:19 | Robert | create | |
|