This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author brian-cameron-oracle
Recipients brian-cameron-oracle, jcea, trent
Date 2013-01-09.17:17:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1357751872.87.0.704791290049.issue16902@psf.upfronthosting.co.za>
In-reply-to
Content
Sure, doing multiple #ifdef's makes sense.  Do you need me to provide an updated patch, or is this something easier for someone who has commit access to the source code repository to just go ahead and do.

I would think this Module would fail to compile if OSS isn't present, no?  So I guess I do not understand your comment about this possibly causing any sort of crash on import at runtime.

The Modules/ossaudiodev.c file should not compile if 
/usr/include/sys/soundcard.h isn't available with OSS definitions.  It wouldn't be on Solaris 10 or earlier.  Is it okay to try and compile this plugin and let it fail if it does?  Or does the configure script need to check this first and only try building it on Solaris 11 or later?
History
Date User Action Args
2013-01-09 17:17:52brian-cameron-oraclesetrecipients: + brian-cameron-oracle, jcea, trent
2013-01-09 17:17:52brian-cameron-oraclesetmessageid: <1357751872.87.0.704791290049.issue16902@psf.upfronthosting.co.za>
2013-01-09 17:17:52brian-cameron-oraclelinkissue16902 messages
2013-01-09 17:17:52brian-cameron-oraclecreate