Author zach.ware
Recipients Arfrever, brett.cannon, eric.araujo, jcea, serhiy.storchaka, zach.ware
Date 2012-12-21.21:05:45
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1356123946.44.0.250454208784.issue16694@psf.upfronthosting.co.za>
In-reply-to
Content
Here's another new version.  Changes include:

- Address Serhiy's Rietveld comments
- Fix length_hint() the way it was meant to be fixed last time.
- Remove __getitem__ check on 'b' in concat and iconcat.  More notes on this below.
- Fix methodcaller as Serhiy suggested
- Add test case for methodcaller for 'name' and 'self' keyword arguments
- Add comments to 'subdivide' the module into the rough sections the docs are divided into.  Move length_hint() with other sequence operations to also match the doc order.

On concat and iconcat: Looking at the glossary, a sequence should actually have both __getitem__ and __len__.  The test class in the test case for iconcat only defines __getitem__, though.  Should we check only for __getitem__ on the first argument, or check for both __getitem__ and __len__, and add __len__ to the test class?  Requiring __len__ may cause breakage for anyone using the Python implementation with a class they defined and used with the C implementation with only __getitem__, so I'm leaning towards only checking for __getitem__.  I can't really tell what the C implementation really looks for as I don't speak C, but it almost looks to me like it may be only checking for __getitem__.  Latest patch only checks argument 'a' for __getitem__.
History
Date User Action Args
2012-12-21 21:05:47zach.waresetrecipients: + zach.ware, brett.cannon, jcea, eric.araujo, Arfrever, serhiy.storchaka
2012-12-21 21:05:46zach.waresetmessageid: <1356123946.44.0.250454208784.issue16694@psf.upfronthosting.co.za>
2012-12-21 21:05:46zach.warelinkissue16694 messages
2012-12-21 21:05:46zach.warecreate