Message177795
Sorry to have disappeared on this, other things took priority...
Thank you for the comments, Serhiy. v2 of the patch renames Modules/operator.c to Modules/_operator.c, and changes that name every place I could find it.
I also tried to tidy up some of the error message mismatches. I didn't bother with the ones regarding missing arguments, as that would mean checking args and throwing an exception in each and every function.
I do like the functional attrgetter better than the object version I wrote. The main reason I went with an object version in the first place was because that's what the C implementation used. Is there any reason not to break with the C implementation and use a function instead? The updated patch takes a rather ugly hack to try to use the functional version in an object.
length_hint() was horrible and has been rewritten. It should be less horrible now :). It should also follow the C implementation quite a bit better. |
|
Date |
User |
Action |
Args |
2012-12-20 01:25:23 | zach.ware | set | recipients:
+ zach.ware, brett.cannon, jcea, Arfrever, serhiy.storchaka |
2012-12-20 01:25:22 | zach.ware | set | messageid: <1355966722.86.0.897111999604.issue16694@psf.upfronthosting.co.za> |
2012-12-20 01:25:22 | zach.ware | link | issue16694 messages |
2012-12-20 01:25:20 | zach.ware | create | |
|