Message 176738 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	jcea
Recipients	bruno.dupuis, jcea
Date	2012-12-01.05:08:32
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1354338513.13.0.307438548889.issue16588@psf.upfronthosting.co.za>
In-reply-to

Content
The warning is legitimate. "error" is set to 0 at the beginning and it will be set to 1 if an error occurred (via CHECK_STATUS macro). But the variable "error" is never used in the function. So it is set, but never actually used in the function. The obvious thing to do is to use the variable. For instance, with an "if (error) {}" do nothing construction. Please, review the patch. I will commit it if another core developer thinks it is ok. Python 2.7, 3.2, 3.3 and 3.4 affected. It you think there is a better way of handling this, let me know. PS: With the default compilation parameters (-O3), that empty "if" is optimized out, as it should.

The warning is legitimate. "error" is set to 0 at the beginning and it will be set to 1 if an error occurred (via CHECK_STATUS macro). But the variable "error" is never used in the function. So it is set, but never actually used in the function.

The obvious thing to do is to use the variable. For instance, with an "if (error) {}" do nothing construction.

Please, review the patch. I will commit it if another core developer thinks it is ok.

Python 2.7, 3.2, 3.3 and 3.4 affected.

It you think there is a better way of handling this, let me know.

PS: With the default compilation parameters (-O3), that empty "if" is optimized out, as it should.

History
Date	User	Action	Args
2012-12-01 05:08:33	jcea	set	recipients: + jcea, bruno.dupuis
2012-12-01 05:08:33	jcea	set	messageid: <1354338513.13.0.307438548889.issue16588@psf.upfronthosting.co.za>
2012-12-01 05:08:32	jcea	link	issue16588 messages
2012-12-01 05:08:32	jcea	create