Message176376
> So this patch is a workaround for poor fseek performance in Microsoft's CRT, it doesn't cause performance issues on Linux but saves quite some milliseconds of startup time so I think it's worth the tradeoff.
I think some clarifying comments will be good in the code. In particular about the `dummy` variable.
> I'll also upload zipimport_speedup-v3.patch updated to apply to current default and with error handling for failing freads since the fseeks that the patch replaces have gained error handling on the default branch in the mean time.
Perhaps getc() requires error handling too. |
|
Date |
User |
Action |
Args |
2012-11-25 17:18:09 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, brett.cannon, ysj.ray, Goplat, catalin.iacob, eric.snow |
2012-11-25 17:18:09 | serhiy.storchaka | set | messageid: <1353863889.0.0.214163244795.issue8745@psf.upfronthosting.co.za> |
2012-11-25 17:18:08 | serhiy.storchaka | link | issue8745 messages |
2012-11-25 17:18:08 | serhiy.storchaka | create | |
|