➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients loewis, mark.dickinson, rhettinger, serhiy.storchaka
Date 2012-11-18.09:14:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1353230082.62.0.809971424673.issue16496@psf.upfronthosting.co.za>
In-reply-to
Content 
Thanks for the updated patch.  A couple more comments:

- you've got potential overflow when computing keysize from bits, on platforms where sizeof(size_t) > sizeof(unsigned long).

- please could you move the check for PY_UINT32_T nearer the top of the file, along with the other #defines.
History
Date User Action Args
2012-11-18 09:14:42mark.dickinsonsetrecipients: + mark.dickinson, loewis, rhettinger, serhiy.storchaka
2012-11-18 09:14:42mark.dickinsonsetmessageid: <1353230082.62.0.809971424673.issue16496@psf.upfronthosting.co.za>
2012-11-18 09:14:42mark.dickinsonlinkissue16496 messages
2012-11-18 09:14:42mark.dickinsoncreate