Message175678
> The patch looks OK, buy can you provide a way to reproduce the error (if you get any)?
No, I have not any. I am even not sure tabnanny works at all. But this bug is obvious. So, let's fix it and go on.
> Should we add tests for tabnanny?
This will be good, but it is a different issue. I'm not ready to write a test.
> I tried to get an error from tabnanny but the only thing I got was a ResourceWarning (that can be easily fixed by a finally: f.close() near the end of the check() method).
I can't see a ResourceWarning. A "finally: f.close()" already exists near the end of the check() method. |
|
Date |
User |
Action |
Args |
2012-11-16 11:07:17 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, georg.brandl, ezio.melotti |
2012-11-16 11:07:16 | serhiy.storchaka | set | messageid: <1353064036.99.0.24139295359.issue16478@psf.upfronthosting.co.za> |
2012-11-16 11:07:16 | serhiy.storchaka | link | issue16478 messages |
2012-11-16 11:07:16 | serhiy.storchaka | create | |
|