Author mark.dickinson
Recipients Sundance, daniel.urban, mark.dickinson, pitrou, sfeltman
Date 2012-11-12.21:32:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1352755949.32.0.566864440744.issue14631@psf.upfronthosting.co.za>
In-reply-to
Content
The patch looks okay to me.

What does inheriting from 'ref' buy you?  This feels a bit strange to me: the way I think of it, the WeakMethod *has* a weakref to the underlying object, rather than *being* a weakref to the underlying object.  The __repr__ also seems a bit misleading as a result:

>>> o = Object()
>>> m = o.some_method
>>> WeakMethod(m)
<weakref at 0x100665ae0; to 'Object' at 0x101115840>
History
Date User Action Args
2012-11-12 21:32:29mark.dickinsonsetrecipients: + mark.dickinson, pitrou, daniel.urban, Sundance, sfeltman
2012-11-12 21:32:29mark.dickinsonsetmessageid: <1352755949.32.0.566864440744.issue14631@psf.upfronthosting.co.za>
2012-11-12 21:32:29mark.dickinsonlinkissue14631 messages
2012-11-12 21:32:29mark.dickinsoncreate