Author pconnell
Recipients pconnell, pitrou, r.david.murray, serhiy.storchaka, vinay.sajip
Date 2012-11-11.13:46:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1352641613.38.0.490750411808.issue16449@psf.upfronthosting.co.za>
In-reply-to
Content
I've updated the type to enhancement (it seems like a grey area to me - it's a behavioural fix for a niche use case).

I suggested a patch rather than simply subclassing RotatingFileHandler since:
  - The subclass would just have a copy of RotatingFileHandler's doRollover method with a one-line change.
  - The proposed fix is functionally equivalent to the current code for all currently working uses.


Thanks for the offer of having an extension linked from your blog. I don't think it's appropriate for this case (since it's just a slightly modified copy of the stdlib code - I'll probably just keep the patch along with a few other compatibility hacks we have) although I may have something for you in future (we do have a subclass that compresses old logs).
History
Date User Action Args
2012-11-11 13:46:53pconnellsetrecipients: + pconnell, vinay.sajip, pitrou, r.david.murray, serhiy.storchaka
2012-11-11 13:46:53pconnellsetmessageid: <1352641613.38.0.490750411808.issue16449@psf.upfronthosting.co.za>
2012-11-11 13:46:53pconnelllinkissue16449 messages
2012-11-11 13:46:53pconnellcreate