Author serhiy.storchaka
Recipients benjamin.peterson, christian.heimes, gregory.p.smith, jcea, pitrou, python-dev, serhiy.storchaka
Date 2012-10-30.22:56:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1351637761.92.0.831994903299.issue16351@psf.upfronthosting.co.za>
In-reply-to
Content
> Because it's much simpler like that.

Well, I wrote a patch with structure sequences, it is really much more expansive.

I have some comments.

1. You can allocate list of NUM_GENERATIONS elements and then use PyList_SET_ITEM(result, i, stat). This is 4 lines shorter.

2. And may be return the tuple? get_count() and get_threshold() return tuples.

3. You forgot to add get_stats() to the module docstring.
History
Date User Action Args
2012-10-30 22:56:01serhiy.storchakasetrecipients: + serhiy.storchaka, gregory.p.smith, jcea, pitrou, christian.heimes, benjamin.peterson, python-dev
2012-10-30 22:56:01serhiy.storchakasetmessageid: <1351637761.92.0.831994903299.issue16351@psf.upfronthosting.co.za>
2012-10-30 22:56:01serhiy.storchakalinkissue16351 messages
2012-10-30 22:56:01serhiy.storchakacreate