Message173976
Issue 12890 fix is now committed. Perhaps I should have worked with yours instead...but I didn't. The test solution in that patch, calling python in a separate process, is conceptually simpler but will take more time to run. I'm on the fence as to which one I prefer, having looked at your patch now...but I'm not sure that your patch cleans up properly, and that fact that that is difficult to figure out argues a bit for the cleaner subprocess solution. I much prefer tests that run fast, though... |
|
Date |
User |
Action |
Args |
2012-10-27 20:27:37 | r.david.murray | set | recipients:
+ r.david.murray, ncoghlan, eric.araujo, aliles |
2012-10-27 20:27:37 | r.david.murray | set | messageid: <1351369657.93.0.336382089027.issue15749@psf.upfronthosting.co.za> |
2012-10-27 20:27:37 | r.david.murray | link | issue15749 messages |
2012-10-27 20:27:37 | r.david.murray | create | |
|