Author yselivanov
Recipients chris.jerdonek, codefisher, docs@python, eric.araujo, ezio.melotti, georg.brandl, loewis, stutzbach, techtonik, terry.reedy, yselivanov
Date 2012-10-26.21:39:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1351287575.02.0.618031447609.issue8040@psf.upfronthosting.co.za>
In-reply-to
Content
> If the issue with patch is closed as duplicate, the patch should be attached to the superseder.

Attached now.  Although, please don't use it.  I'll upload an updated version soon.

> The patch looks awfully long for such a simple option list. (e.g., get_version() is just lambda x: x[:3], no need for a function to do that.)

Well, I've tried to make it readable.  I can uglify it, but it won't save too much.  Right now it's about ~2.5kb.

> Please make it configurable, as indicated. You can add an option recognized by Sphinx in Doc/tools/sphinxext/pyspecific.py, with app.add_config_value.  I will then set it properly in the script that rebuilds the docs on docs.python.org.

Is it OK if I make it configurable via theme config property?
And if not - how to make a config option declared via 'app.add_config_value' accessible in templates?
History
Date User Action Args
2012-10-26 21:39:35yselivanovsetrecipients: + yselivanov, loewis, georg.brandl, terry.reedy, techtonik, stutzbach, ezio.melotti, eric.araujo, chris.jerdonek, docs@python, codefisher
2012-10-26 21:39:35yselivanovsetmessageid: <1351287575.02.0.618031447609.issue8040@psf.upfronthosting.co.za>
2012-10-26 21:39:34yselivanovlinkissue8040 messages
2012-10-26 21:39:34yselivanovcreate