Message173890
A few comments:
* If the issue with patch is closed as duplicate, the patch should be attached to the superseder.
* The patch looks awfully long for such a simple option list. (e.g., get_version() is just lambda x: x[:3], no need for a function to do that.)
* Keep in mind that you can't easily support 2.5 and down anyway, since their URLs are completely different. I call YAGNI on including anything older than 2.6.
* Please make it configurable, as indicated. You can add an option recognized by Sphinx in Doc/tools/sphinxext/pyspecific.py, with app.add_config_value. I will then set it properly in the script that rebuilds the docs on docs.python.org.
That said, the result looks nice. If we can work out the specifics, +1 for something like it. |
|
Date |
User |
Action |
Args |
2012-10-26 21:22:42 | georg.brandl | set | recipients:
+ georg.brandl, loewis, terry.reedy, techtonik, stutzbach, ezio.melotti, eric.araujo, chris.jerdonek, docs@python, codefisher, yselivanov |
2012-10-26 21:22:42 | georg.brandl | set | messageid: <1351286562.23.0.210390203015.issue8040@psf.upfronthosting.co.za> |
2012-10-26 21:22:42 | georg.brandl | link | issue8040 messages |
2012-10-26 21:22:42 | georg.brandl | create | |
|