Author serhiy.storchaka
Recipients ezio.melotti, pitrou, serhiy.storchaka, vstinner
Date 2012-10-26.15:42:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1351266176.96.0.911861478569.issue16330@psf.upfronthosting.co.za>
In-reply-to
Content
A set of macros to work with surrogates was introduced in 3.3: Py_UNICODE_IS_SURROGATE, Py_UNICODE_IS_HIGH_SURROGATE, Py_UNICODE_IS_LOW_SURROGATE, Py_UNICODE_JOIN_SURROGATES, Py_UNICODE_HIGH_SURROGATE, and Py_UNICODE_LOW_SURROGATE.  Using this macros makes a code more readable, protect from errors, and allows use the one most effective implementation.  But not all surrogate-related code uses this macros.  I suppose this is done inadvertently, somewhere the macro and naked code used in neighboring lines.

The proposed patch replaces a naked surrogate code to macros in all places except expat (which is a foreign code).
History
Date User Action Args
2012-10-26 15:42:57serhiy.storchakasetrecipients: + serhiy.storchaka, pitrou, vstinner, ezio.melotti
2012-10-26 15:42:56serhiy.storchakasetmessageid: <1351266176.96.0.911861478569.issue16330@psf.upfronthosting.co.za>
2012-10-26 15:42:56serhiy.storchakalinkissue16330 messages
2012-10-26 15:42:56serhiy.storchakacreate