Author hynek
Recipients Bbb, Janne.Karila, hynek, sbt
Date 2012-10-26.10:56:37
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1351248998.09.0.615752630609.issue16307@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for taking the time! I remember my frustrations when trying to grok how the mp test suite works. :)

A small nit-pick first: you have a lot of extra white space in your patches. Just run 'make patchcheck' first, that should warn you about that.

Not sure, but the tests look rather complex to me. I’d humbly propose the the simplified test attached, which also ensures that error_callback get only called on errors and callback on success.

Opinions?
History
Date User Action Args
2012-10-26 10:56:38hyneksetrecipients: + hynek, sbt, Janne.Karila, Bbb
2012-10-26 10:56:38hyneksetmessageid: <1351248998.09.0.615752630609.issue16307@psf.upfronthosting.co.za>
2012-10-26 10:56:38hyneklinkissue16307 messages
2012-10-26 10:56:37hynekcreate