Author trent
Recipients giampaolo.rodola, jcea, python-dev, trent
Date 2012-10-24.12:13:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <20121024121310.GB5339@snakebite.org>
In-reply-to <1350910283.16.0.705422263646.issue16274@psf.upfronthosting.co.za>
Content
On Mon, Oct 22, 2012 at 05:51:23AM -0700, Giampaolo Rodola' wrote:
> 
> Giampaolo Rodola' added the comment:
> 
> This should do it:
> 
> diff --git a/Lib/test/test_asyncore.py b/Lib/test/test_asyncore.py
> --- a/Lib/test/test_asyncore.py
> +++ b/Lib/test/test_asyncore.py
> @@ -484,8 +484,9 @@
>          return self.socket.getsockname()[:2]
>  
>      def handle_accept(self):
> -        sock, addr = self.accept()
> -        self.handler(sock)
> +        pair = self.accept()
> +        if pair is not None:
> +            self.handler(pair[0])
>  
>      def handle_error(self):
>          raise

    Yeah this looks a lot more appropriate than the two changes
    Jesús posted.  I'll test against my Solaris boxes and report
    back.
History
Date User Action Args
2012-10-24 12:13:16trentsetrecipients: + trent, jcea, giampaolo.rodola, python-dev
2012-10-24 12:13:16trentlinkissue16274 messages
2012-10-24 12:13:15trentcreate