Message173362
> It seems simple enough for us to make the default configurable
This seems good to do in any case (as opposed to having the string be "hard-coded"), and we can test it independently of Android. There is a recently added test in the 3.x branches that can be modified: test method "test_executable_replaces_shell" which checks that the executable argument replaces the default shell for non-Windows.
I would suggest implementing Gregory's two suggested measures as two separate patches. |
|
Date |
User |
Action |
Args |
2012-10-19 22:59:21 | chris.jerdonek | set | recipients:
+ chris.jerdonek, gregory.p.smith, eric.araujo, rpetrov, r.david.murray, asvetlov, brousch |
2012-10-19 22:59:21 | chris.jerdonek | set | messageid: <1350687561.02.0.568464345418.issue16255@psf.upfronthosting.co.za> |
2012-10-19 22:59:21 | chris.jerdonek | link | issue16255 messages |
2012-10-19 22:59:20 | chris.jerdonek | create | |
|