Author chris.jerdonek
Recipients Arfrever, asvetlov, chris.jerdonek, gregory.p.smith, python-dev
Date 2012-10-10.11:25:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
I made some comments on the changes as committed here:

It would be cleaner to use the self.assertRaises() pattern here and
also probably better to share code across the three test methods which
are nearly identical to one another (there is a fourth scenario I
would also add of shell=True).

I would also check for FileNotFoundError instead of OSError in the 3.3
and later versions.
Date User Action Args
2012-10-10 11:25:39chris.jerdoneksetrecipients: + chris.jerdonek, gregory.p.smith, Arfrever, asvetlov, python-dev
2012-10-10 11:25:39chris.jerdoneksetmessageid: <>
2012-10-10 11:25:39chris.jerdoneklinkissue16114 messages
2012-10-10 11:25:38chris.jerdonekcreate