Author pitrou
Recipients asvetlov, jcea, pitrou, sbt, serhiy.storchaka
Date 2012-10-05.13:03:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1349442191.77.0.617143853223.issue15528@psf.upfronthosting.co.za>
In-reply-to
Content
In:

+                    except:
+                        sys.excepthook(*sys.exc_info())

I would write "except Exception" instead. You don't want to trap e.g. KeyboardInterrupt.

For clarity, I would also add "_dirty = False" at the finalize top-level.
Otherwise, looks fine to me.
History
Date User Action Args
2012-10-05 13:03:11pitrousetrecipients: + pitrou, jcea, asvetlov, sbt, serhiy.storchaka
2012-10-05 13:03:11pitrousetmessageid: <1349442191.77.0.617143853223.issue15528@psf.upfronthosting.co.za>
2012-10-05 13:03:11pitroulinkissue15528 messages
2012-10-05 13:03:11pitroucreate