Message171681
Hi, Martin,
On 20 August 2012 05:25, Martin v. Löwis <report@bugs.python.org> wrote:
> Martin v. Löwis added the comment:
>
> (As usual), I'm quite skeptical about this "bulk bug report"; it violates the "one bug at a time" principle, where "one bug" can roughly be defined as "cannot be split into smaller independent issues".
I heartily agree with you in general: as well as being non-atomic,
it's also hard to have a clear test whether such bugs are fixed. But,
I hope this patch has some value even if the bug is not a great
example.
> For the cases at hand, I think it would be best if somebody with gcc 4.6 available just fixed the "easy" ones, i.e. where the code clearly improves when silenciing the warning. In these cases, I wouldn't mind if they get checked in without code review; I know some favor review for all changes, in which case a separate issue should be opened for a patch fixing a bunch of these.
I've fixed what I believe to be all the safe/easy warnings in my patch
above. I would appreciate if someone would review it and if possible
commit it. |
|
Date |
User |
Action |
Args |
2012-09-30 22:58:09 | poolie | set | recipients:
+ poolie, loewis, brett.cannon, terry.reedy, jcea, vstinner, python-dev, kidanger |
2012-09-30 22:58:09 | poolie | link | issue10951 messages |
2012-09-30 22:58:09 | poolie | create | |
|