Author maker
Recipients abacabadabacaba, belopolsky, eric.smith, ezio.melotti, maker, mark.dickinson, r.david.murray, rhettinger, serhiy.storchaka, stutzbach
Date 2012-09-25.19:27:16
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1348601257.75.0.399651616097.issue8425@psf.upfronthosting.co.za>
In-reply-to
Content
> I'm not sure of the usefulness of this comment.
removing, then.

> "else" redundant here.

> Instead of using a local variable "intersected", you can simply add "else
> Py_INCREF(other)" here and then decref "other" unconditionally. It will be
> shorter and perhaps a little clearer, but a bit slower.

I find my first patch more readable and efficient, but if these comments are conformant to pep7.. 
Attaching updated patch (issue8425.3.patch)


> Did you run benchmarks in debug mode?
Yes, but bench.py is available, fell free to run it with whatever configuration; my example was done with a --with-pydebug and clang compiler. 

> In order for results to be convenient to compare please sort it by name.
Done.
History
Date User Action Args
2012-09-25 19:27:37makersetrecipients: + maker, rhettinger, mark.dickinson, belopolsky, eric.smith, stutzbach, ezio.melotti, r.david.murray, abacabadabacaba, serhiy.storchaka
2012-09-25 19:27:37makersetmessageid: <1348601257.75.0.399651616097.issue8425@psf.upfronthosting.co.za>
2012-09-25 19:27:16makerlinkissue8425 messages
2012-09-25 19:27:16makercreate