Message170594
I disagree that sizeof cannot work well for variable-sized types. It works very well for strings, lists, tuple, dicts, and other "regular" containers. I agree that it is not important that it is absolutely correct (in some sense) for every object, but it shouldn't lose "big" chunks of data. A bug where it misses four bytes is much less important than a bug where it misses N bytes (for an object-specific value N that can grow indefinitely).
As for the specific patch, I don't think any action should be taken before the 3.3 release. I would personally prefer if the computations where done in Py_ssize_t, not PyObject* (i.e. the result of the recursive call should be unwrapped). |
|
Date |
User |
Action |
Args |
2012-09-17 11:18:29 | loewis | set | recipients:
+ loewis, jcea, pitrou, benjamin.peterson, stutzbach, aliles, hynek, serhiy.storchaka |
2012-09-17 11:18:29 | loewis | set | messageid: <1347880709.5.0.732473252408.issue15490@psf.upfronthosting.co.za> |
2012-09-17 11:18:29 | loewis | link | issue15490 messages |
2012-09-17 11:18:28 | loewis | create | |
|