This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients Robin.Schreiber, asvetlov, belopolsky, pitrou
Date 2012-09-10.02:46:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
For some reason there are no review links, so I'll review in this message.


+typedef struct {
+} _datetimemodulestate;

Names exposed in public headers (datetime.h is a public header) should start with Py or _Py. Other offenders include _datetimemodule_state, _datetimemodule, _datetimemodulestate_global.

I don't think these names need to be defined in the header file at all.  

+typedef struct {
+    /* Forward declarations. */
+    PyObject *PyDateTime_DateType;
+    PyObject *PyDateTime_DateTimeType;

These are not forward declarations anymore.  There is no need for PyDateTime_ prefix.  Use names from  PyDateTime_CAPI struct.
Date User Action Args
2012-09-10 02:46:41belopolskysetrecipients: + belopolsky, pitrou, asvetlov, Robin.Schreiber
2012-09-10 02:46:41belopolskysetmessageid: <>
2012-09-10 02:46:40belopolskylinkissue15390 messages
2012-09-10 02:46:40belopolskycreate